From 0ea66329b84cc6e4f8ff61ee99c00bb238070247 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Sun, 2 Aug 2015 14:00:18 +0900 Subject: Performance tuning - eager rune array conversion > wc -l /tmp/list2 2594098 /tmp/list2 > time cat /tmp/list2 | fzf-0.10.1-darwin_amd64 -fqwerty > /dev/null real 0m5.418s user 0m10.990s sys 0m1.302s > time cat /tmp/list2 | fzf-head -fqwerty > /dev/null real 0m4.862s user 0m6.619s sys 0m0.982s --- src/chunklist.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/chunklist.go') diff --git a/src/chunklist.go b/src/chunklist.go index ee52d321..c20ffd43 100644 --- a/src/chunklist.go +++ b/src/chunklist.go @@ -7,7 +7,7 @@ type Chunk []*Item // >>> []Item // ItemBuilder is a closure type that builds Item object from a pointer to a // string and an integer -type ItemBuilder func(*string, int) *Item +type ItemBuilder func([]rune, int) *Item // ChunkList is a list of Chunks type ChunkList struct { @@ -26,7 +26,7 @@ func NewChunkList(trans ItemBuilder) *ChunkList { trans: trans} } -func (c *Chunk) push(trans ItemBuilder, data *string, index int) bool { +func (c *Chunk) push(trans ItemBuilder, data []rune, index int) bool { item := trans(data, index) if item != nil { *c = append(*c, item) @@ -53,7 +53,7 @@ func CountItems(cs []*Chunk) int { } // Push adds the item to the list -func (cl *ChunkList) Push(data string) bool { +func (cl *ChunkList) Push(data []rune) bool { cl.mutex.Lock() defer cl.mutex.Unlock() @@ -62,7 +62,7 @@ func (cl *ChunkList) Push(data string) bool { cl.chunks = append(cl.chunks, &newChunk) } - if cl.lastChunk().push(cl.trans, &data, cl.count) { + if cl.lastChunk().push(cl.trans, data, cl.count) { cl.count++ return true } -- cgit v1.2.3