From 555b0d235bd29ace645c263ef2fdb744717f8885 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Sat, 1 Jun 2024 14:13:24 +0900 Subject: Ignore --height option if it's not supported on the platform This is to make shell integration work out of the box on Git bash. eval "$(fzf --bash)" vim # would print '--height option is currently not supported on this platform' --- src/winpty_windows.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/winpty_windows.go') diff --git a/src/winpty_windows.go b/src/winpty_windows.go index a9e56bbd..29cd0f90 100644 --- a/src/winpty_windows.go +++ b/src/winpty_windows.go @@ -24,12 +24,11 @@ func needWinpty(opts *Options) bool { See: https://github.com/junegunn/fzf/issues/3809 "MSYS=enable_pcon" allows fzf to run properly on mintty 3.4.5 or later, - however `--height` option still doesn't work, so let's just disable it. + however `--height` option still doesn't work, and it's going to be ignored. We're not going to worry too much about restoring the original value. */ if strings.Contains(os.Getenv("MSYS"), "enable_pcon") { - opts.Height = heightSpec{} return false } -- cgit v1.2.3