From 64bd9053a25297f7a442ca831c7da5b44bd33f84 Mon Sep 17 00:00:00 2001 From: jacqueline Date: Wed, 12 Jun 2024 17:54:40 +1000 Subject: Update LVGL to v9.1.0 --- lib/lvgl/.github/pull_request_template.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'lib/lvgl/.github/pull_request_template.md') diff --git a/lib/lvgl/.github/pull_request_template.md b/lib/lvgl/.github/pull_request_template.md index 32edffd7..37fb1120 100644 --- a/lib/lvgl/.github/pull_request_template.md +++ b/lib/lvgl/.github/pull_request_template.md @@ -2,7 +2,12 @@ A clear and concise description of what the bug or new feature is. -### Checkpoints -- [ ] Follow the [styling guide](https://github.com/lvgl/lvgl/blob/master/docs/CODING_STYLE.md) -- [ ] Run `code-format.py` from the `scripts` folder. [astyle](http://astyle.sourceforge.net/install.html) needs to be installed. -- [ ] Update the documentation +### Notes +- Update the [Documentation](https://github.com/lvgl/lvgl/tree/master/docs) if needed. +- Add [Examples](https://github.com/lvgl/lvgl/tree/master/examples) if relevant. +- Add [Tests](https://github.com/lvgl/lvgl/blob/master/tests/README.md) if applicable. +- If you added new options to `lv_conf_template.h` run [lv_conf_internal_gen.py](https://github.com/lvgl/lvgl/blob/master/scripts/lv_conf_internal_gen.py) and update [Kconfig](https://github.com/lvgl/lvgl/blob/master/Kconfig). +- Run `scripts/code-format.py` ([astyle](http://astyle.sourceforge.net/install.html) version [v3.4.10](https://github.com/szepeviktor/astyle/releases/tag/v3.4.10) needs to be installed) and follow the [Code Conventions](https://docs.lvgl.io/master/CODING_STYLE.html). +- Mark the Pull request as [Draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request) while you are working on the first version, and mark is as _Ready_ when it's ready for review. +- When changes were requested, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review) to notify the maintainers. +- Help us to review this Pull Request! Anyone can [approve or request changes](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews). -- cgit v1.2.3