From 9512bd97bbac48fa33339cc248c76070063bbc61 Mon Sep 17 00:00:00 2001
From: ailurux <ailuruxx@gmail.com>
Date: Mon, 12 Feb 2024 15:36:56 +1100
Subject: Add buttons for shuffle + repeat track

---
 src/audio/audio_fsm.cpp           |  2 +-
 src/audio/include/track_queue.hpp | 14 ++++++++++++--
 src/audio/track_queue.cpp         | 40 +++++++++++++++++++++++++++++----------
 3 files changed, 43 insertions(+), 13 deletions(-)

(limited to 'src/audio')

diff --git a/src/audio/audio_fsm.cpp b/src/audio/audio_fsm.cpp
index 54ffa51d..b80e8c30 100644
--- a/src/audio/audio_fsm.cpp
+++ b/src/audio/audio_fsm.cpp
@@ -320,7 +320,7 @@ void Playback::react(const internal::InputFileClosed& ev) {}
 
 void Playback::react(const internal::InputFileFinished& ev) {
   ESP_LOGI(kTag, "finished playing file");
-  sServices->track_queue().next();
+  sServices->track_queue().finish();
   if (!sServices->track_queue().current()) {
     transit<Standby>();
   }
diff --git a/src/audio/include/track_queue.hpp b/src/audio/include/track_queue.hpp
index 5b14fd4a..fd6061a7 100644
--- a/src/audio/include/track_queue.hpp
+++ b/src/audio/include/track_queue.hpp
@@ -33,13 +33,13 @@ class RandomIterator {
 
   // Note resizing has the side-effect of restarting iteration.
   auto resize(size_t) -> void;
-  auto repeat(bool) -> void;
+  auto replay(bool) -> void;
 
  private:
   size_t seed_;
   size_t pos_;
   size_t size_;
-  bool repeat_;
+  bool replay_;
 };
 
 /*
@@ -85,6 +85,12 @@ class TrackQueue {
   auto next() -> void;
   auto previous() -> void;
 
+  /* 
+   * Called when the current track finishes
+   */
+  auto finish() -> void;
+
+
   auto skipTo(database::TrackId) -> void;
 
   /*
@@ -98,6 +104,9 @@ class TrackQueue {
   auto repeat(bool) -> void;
   auto repeat() const -> bool;
 
+  auto replay(bool) -> void;
+  auto replay() const -> bool;
+
   auto serialise() -> std::string;
   auto deserialise(const std::string&) -> void;
 
@@ -115,6 +124,7 @@ class TrackQueue {
 
   std::optional<RandomIterator> shuffle_;
   bool repeat_;
+  bool replay_;
 };
 
 }  // namespace audio
diff --git a/src/audio/track_queue.cpp b/src/audio/track_queue.cpp
index d68f2821..5ac9d1f8 100644
--- a/src/audio/track_queue.cpp
+++ b/src/audio/track_queue.cpp
@@ -34,12 +34,12 @@ namespace audio {
 [[maybe_unused]] static constexpr char kTag[] = "tracks";
 
 RandomIterator::RandomIterator(size_t size)
-    : seed_(), pos_(0), size_(size), repeat_(false) {
+    : seed_(), pos_(0), size_(size), replay_(false) {
   esp_fill_random(&seed_, sizeof(seed_));
 }
 
 auto RandomIterator::current() const -> size_t {
-  if (pos_ < size_ || repeat_) {
+  if (pos_ < size_ || replay_) {
     return MillerShuffle(pos_, seed_, size_);
   }
   return size_;
@@ -65,8 +65,8 @@ auto RandomIterator::resize(size_t s) -> void {
   pos_ = 0;
 }
 
-auto RandomIterator::repeat(bool r) -> void {
-  repeat_ = r;
+auto RandomIterator::replay(bool r) -> void {
+  replay_ = r;
 }
 
 auto notifyChanged(bool current_changed) -> void {
@@ -81,7 +81,8 @@ TrackQueue::TrackQueue(tasks::WorkerPool& bg_worker)
       pos_(0),
       tracks_(&memory::kSpiRamResource),
       shuffle_(),
-      repeat_(false) {}
+      repeat_(false),
+      replay_(false) {}
 
 auto TrackQueue::current() const -> std::optional<database::TrackId> {
   const std::shared_lock<std::shared_mutex> lock(mutex_);
@@ -202,7 +203,7 @@ auto TrackQueue::next() -> void {
     pos_ = shuffle_->current();
   } else {
     if (pos_ + 1 >= tracks_.size()) {
-      if (repeat_) {
+      if (replay_) {
         pos_ = 0;
       }
     } else {
@@ -231,6 +232,14 @@ auto TrackQueue::previous() -> void {
   notifyChanged(true);
 }
 
+auto TrackQueue::finish() -> void {
+  if (repeat_) {
+    notifyChanged(true);
+  } else {
+    next();
+  }
+}
+
 auto TrackQueue::skipTo(database::TrackId id) -> void {
   // Defer this work to the background not because it's particularly
   // long-running (although it could be), but because we want to ensure we only
@@ -279,7 +288,7 @@ auto TrackQueue::random(bool en) -> void {
     // repeated calls with en == true will re-shuffle.
     if (en) {
       shuffle_.emplace(tracks_.size());
-      shuffle_->repeat(repeat_);
+      shuffle_->replay(replay_);
     } else {
       shuffle_.reset();
     }
@@ -298,9 +307,6 @@ auto TrackQueue::repeat(bool en) -> void {
   {
     const std::unique_lock<std::shared_mutex> lock(mutex_);
     repeat_ = en;
-    if (shuffle_) {
-      shuffle_->repeat(en);
-    }
   }
 
   notifyChanged(false);
@@ -311,6 +317,20 @@ auto TrackQueue::repeat() const -> bool {
   return repeat_;
 }
 
+auto TrackQueue::replay(bool en) -> void {
+  const std::unique_lock<std::shared_mutex> lock(mutex_);
+  replay_ = en;
+  if (shuffle_) {
+    shuffle_->replay(en);
+  }
+  notifyChanged(false);
+}
+
+auto TrackQueue::replay() const -> bool {
+  const std::shared_lock<std::shared_mutex> lock(mutex_);
+  return replay_;
+}
+
 auto TrackQueue::serialise() -> std::string {
   cppbor::Array tracks{};
   for (database::TrackId track : tracks_) {
-- 
cgit v1.2.3


From 527374c72e1ec52e1d5814dbee3587ae100631dd Mon Sep 17 00:00:00 2001
From: ailurux <ailuruxx@gmail.com>
Date: Mon, 12 Feb 2024 16:26:37 +1100
Subject: Don't hold lock on notifyChanged

---
 src/audio/track_queue.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

(limited to 'src/audio')

diff --git a/src/audio/track_queue.cpp b/src/audio/track_queue.cpp
index 5ac9d1f8..c4c101f6 100644
--- a/src/audio/track_queue.cpp
+++ b/src/audio/track_queue.cpp
@@ -318,10 +318,12 @@ auto TrackQueue::repeat() const -> bool {
 }
 
 auto TrackQueue::replay(bool en) -> void {
-  const std::unique_lock<std::shared_mutex> lock(mutex_);
-  replay_ = en;
-  if (shuffle_) {
-    shuffle_->replay(en);
+  {
+    const std::unique_lock<std::shared_mutex> lock(mutex_);
+    replay_ = en;
+    if (shuffle_) {
+      shuffle_->replay(en);
+    }
   }
   notifyChanged(false);
 }
-- 
cgit v1.2.3