From 5ac4d3949cd7430e0d4c994bbc528e8e4fa91337 Mon Sep 17 00:00:00 2001 From: jacqueline Date: Mon, 22 May 2023 15:23:51 +1000 Subject: Generalise worker tasks, and centralise task priorities + stacks Includes making the display driver use a worker task for flushes, so that our double buffering actually does something useful /facepalm --- src/database/include/database.hpp | 6 +++++- src/database/include/db_task.hpp | 25 ------------------------- src/database/include/env_esp.hpp | 5 +++++ 3 files changed, 10 insertions(+), 26 deletions(-) delete mode 100644 src/database/include/db_task.hpp (limited to 'src/database/include') diff --git a/src/database/include/database.hpp b/src/database/include/database.hpp index da0ed083..ce2ca9fe 100644 --- a/src/database/include/database.hpp +++ b/src/database/include/database.hpp @@ -19,6 +19,7 @@ #include "result.hpp" #include "song.hpp" #include "tag_parser.hpp" +#include "tasks.hpp" namespace database { @@ -90,6 +91,8 @@ class Database { leveldb::DB* db_; leveldb::Cache* cache_; + std::shared_ptr worker_task_; + // Not owned. IFileGatherer* file_gatherer_; ITagParser* tag_parser_; @@ -97,7 +100,8 @@ class Database { Database(leveldb::DB* db, leveldb::Cache* cache, IFileGatherer* file_gatherer, - ITagParser* tag_parser); + ITagParser* tag_parser, + std::shared_ptr worker); auto dbMintNewSongId() -> SongId; auto dbEntomb(SongId song, uint64_t hash) -> void; diff --git a/src/database/include/db_task.hpp b/src/database/include/db_task.hpp deleted file mode 100644 index 39f932b0..00000000 --- a/src/database/include/db_task.hpp +++ /dev/null @@ -1,25 +0,0 @@ -#pragma once - -#include -#include -#include - -namespace database { - -auto StartDbTask() -> bool; -auto QuitDbTask() -> void; - -auto SendToDbTask(std::function fn) -> void; - -template -auto RunOnDbTask(std::function fn) -> std::future { - std::shared_ptr> promise = - std::make_shared>(); - SendToDbTask([=]() { promise->set_value(std::invoke(fn)); }); - return promise->get_future(); -} - -template <> -auto RunOnDbTask(std::function fn) -> std::future; - -} // namespace database diff --git a/src/database/include/env_esp.hpp b/src/database/include/env_esp.hpp index cf5a20e1..6a415ce6 100644 --- a/src/database/include/env_esp.hpp +++ b/src/database/include/env_esp.hpp @@ -1,5 +1,6 @@ #pragma once +#include #include #include #include @@ -7,8 +8,12 @@ #include "leveldb/env.h" #include "leveldb/status.h" +#include "tasks.hpp" + namespace leveldb { +extern std::weak_ptr sBackgroundThread; + // Tracks the files locked by EspEnv::LockFile(). // // We maintain a separate set instead of relying on fcntl(F_SETLK) because -- cgit v1.2.3