From 30aaefca64445efa421edb93403036d59382920f Mon Sep 17 00:00:00 2001 From: jacqueline Date: Thu, 8 Aug 2024 14:35:53 +1000 Subject: Batch up the db operations associated with adding new tracks This is ostensibly yet another 'prepare for multithreaded updates' commit, however it does actually save us another 60(!!) odd milliseconds per track. --- src/tangara/database/track.cpp | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'src/tangara/database/track.cpp') diff --git a/src/tangara/database/track.cpp b/src/tangara/database/track.cpp index 5bf8c3e2..461f4561 100644 --- a/src/tangara/database/track.cpp +++ b/src/tangara/database/track.cpp @@ -293,15 +293,4 @@ auto TrackTags::Hash() const -> uint64_t { return komihash_stream_final(&stream); } -auto Track::TitleOrFilename() const -> std::pmr::string { - auto title = tags().title(); - if (title) { - return *title; - } - auto start = data().filepath.find_last_of('/'); - if (start == std::pmr::string::npos) { - return data().filepath; - } - return data().filepath.substr(start + 1); -} } // namespace database -- cgit v1.2.3 From e6921dc0556d567557b5673a475199121898421f Mon Sep 17 00:00:00 2001 From: jacqueline Date: Tue, 3 Sep 2024 11:17:13 +1000 Subject: Use libogg + our own parser for ogg files This is somewhat faster than relying on libtags to parse these, and also better handles cornercases such as tags that cross physical page boundaries. --- src/tangara/database/track.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/tangara/database/track.cpp') diff --git a/src/tangara/database/track.cpp b/src/tangara/database/track.cpp index 461f4561..cdb7543c 100644 --- a/src/tangara/database/track.cpp +++ b/src/tangara/database/track.cpp @@ -148,7 +148,7 @@ auto TrackTags::set(Tag t, std::string_view v) -> void { track(v); break; case Tag::kAlbumOrder: - // This tag is derices from disc and track, and so it can't be set. + // This tag is derived from disc and track, and so it can't be set. break; case Tag::kGenres: genres(v); -- cgit v1.2.3